VDB
Sign up
MEDIUM6.5

GHSA-wwrj-3hvj-prpm

Misskey has a login rate limit bypass via spoofed X-Forwarded-For header

Quick fix

GHSA-wwrj-3hvj-prpm — misskey-js: upgrade to the fixed version with the command below.

npm install misskey-js@2025.12.0-alpha.2

Details

### Summary When using an untrusted reverse proxy or not using a reverse proxy at all, attackers can bypass IP rate limiting by adding a forged X-Forwarded-For header. Starting with version 2025.9.1, an option (`trustProxy`) has been added in config file to prevent this from happening. However, it is initialized with an insecure default value before version 2025.12.0, making it still vulnerable if the configuration is not set correctly.

### Workaround

If you are running Misskey with a trusted reverse proxy, you should *not* be affected by this vulnerability.

- There is no workaround for the Misskey itself. Please update Misskey to the latest version or set up a trusted reverse proxy. - From v2025.9.1 to v2025.11.1, workaround is available. Set `trustProxy: false` in config file. - This is patched in v2025.12.0 by flipping default value of `trustProxy` to `false`. If you are using trusted reverse proxy and not remember you manually overrided this value, please take time to check your config for optimal behavior.

### Details [Fastify recommend not trusting X-Forwarded-For IPs](https://fastify.dev/docs/latest/Reference/Server/#trustproxy) Due to misconfiguration in https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/SigninApiService.ts#L94 attacks can spoof their IPs.

### PoC

``` POST /api/signin-flow HTTP/1.1 Host: misskey.localhost:3123 Content-Length: 45 Content-Type: application/json Connection: keep-alive X-Forwarded-For: 127.1.1.31, 1.1.1.12

{"username":"admin", "password":"password"} ``` ![image](https://github.com/user-attachments/assets/ce9f77e2-b339-4081-86a6-d44ed42e9ca5)

### Impact An attacker can brute force accounts bypassing rate limiting protection.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/misskey-js
Introduced in: 2025.9.1Fixed in: 2025.12.0-alpha.2
Fixnpm install misskey-js@2025.12.0-alpha.2

References