VDB
Sign up
HIGH7.5

GHSA-wp97-x4hv-qvhp

Seroval `fromJSON`/`fromCrossJSON` denial of service via unvalidated array node length

Quick fix

GHSA-wp97-x4hv-qvhp — seroval: upgrade to the fixed version with the command below.

npm install seroval@1.6.8

Details

### Summary

`fromJSON` and `fromCrossJSON` did not check that an array node's element list is an array. A small crafted payload could set the length the decoder used. That length controlled how much memory was allocated and how many times the decoder looped, and it did not depend on the size of the payload.

### Impact

A service that passes untrusted input to `fromJSON` or `fromCrossJSON` can be made unavailable by an unauthenticated request.

- A small payload can allocate enough memory to end the process. - A small payload can block the thread for seconds, or without end.

This affects any framework that decodes request bodies with these functions before its own validation runs.

This issue is a bypass of the fix for GHSA-66fc-rw6m-c2q6 in 1.4.1.

### Patches

Fixed in `seroval@1.6.8`. The deserializer now rejects any node whose element list is not an array, and throws `SerovalMalformedNodeError`.

### Workarounds

None. Upgrade to 1.6.8.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/seroval
Introduced in: 1.4.1Fixed in: 1.6.8
Fixnpm install seroval@1.6.8

References