VDB
Sign up
MEDIUM

GHSA-qvc4-78gw-pv8p

Adverserial use of `make_bitflags!` macro can cause undefined behavior

Details

The macro relied on an expression of the form `Enum::Variant` always being a variant of the enum. However, it may also be an associated integer constant, in which case there's no guarantee that the value of said constant consists only of bits valid for this bitflag type.

Thus, code like this could create an invalid `BitFlags<Test>`, which would cause iterating over it to trigger undefined behavior. As the debug formatter internally iterates over the value, it is also affected.

```rust use enumflags2::{bitflags, make_bitflags};

#[bitflags] #[repr(u8)] #[derive(Copy, Clone, Debug)] enum Test { A = 1, B = 2, }

impl Test { const C: u8 = 69; }

fn main() { let x = make_bitflags!(Test::{C}); // printing or iterating over x is UB } ```

Are you affected?

Enter the version of the package you're using.

Affected packages

crates.io/enumflags2
Introduced in: 0.7.0Fixed in: 0.7.7

Upgrade enumflags2 to 0.7.7 or newer (ecosystem crates.io).

References