VDB
Sign up
MEDIUM5.3

GHSA-mx2q-35m2-x2rh

OpenZeppelin Contracts TransparentUpgradeableProxy clashing selector calls may not be delegated

Quick fix

GHSA-mx2q-35m2-x2rh — @openzeppelin/contracts: upgrade to the fixed version with the command below.

npm install @openzeppelin/contracts@4.8.3

Details

### Impact

A function in the implementation contract may be inaccessible if its selector clashes with one of the proxy's own selectors. Specifically, if the clashing function has a different signature with incompatible ABI encoding, the proxy could revert while attempting to decode the arguments from calldata.

The probability of an accidental clash is negligible, but one could be caused deliberately.

### Patches

The issue has been fixed in v4.8.3.

### Workarounds

If a function appears to be inaccessible for this reason, it may be possible to craft the calldata such that ABI decoding does not fail at the proxy and the function is properly proxied through.

### References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4154

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/@openzeppelin/contracts
Introduced in: 3.2.0Fixed in: 4.8.3
Fixnpm install @openzeppelin/contracts@4.8.3
npm/@openzeppelin/contracts-upgradeable
Introduced in: 3.2.0Fixed in: 4.8.3
Fixnpm install @openzeppelin/contracts-upgradeable@4.8.3

References