VDB
Sign up
HIGH

GHSA-mp4x-c34x-wv3x

Feathers has an origin validation bypass via prefix matching

Quick fix

GHSA-mp4x-c34x-wv3x — @feathersjs/authentication-oauth: upgrade to the fixed version with the command below.

npm install @feathersjs/authentication-oauth@5.0.40

Details

The origin validation uses `startsWith()` for comparison, allowing attackers to bypass the check by registering a domain that shares a common prefix with an allowed origin.

The `getAllowedOrigin()` function checks if the Referer header starts with any allowed origin: ```javascript // https://github.com/feathersjs/feathers/blob/dove/packages/authentication-oauth/src/strategy.ts#L75 const allowedOrigin = origins.find((current) => referer.toLowerCase().startsWith(current.toLowerCase())); ```

This comparison is insufficient as it only validates the prefix. This is exploitable when the `origins` array is configured and an attacker registers a domain starting with an allowed origin string (e.g., `https://target.com.attacker.com` bypasses `https://target.com`).

On its own, tokens are still redirected to a configured origin. However, in specific scenarios an attacker can initiate the OAuth flow from an unauthorized origin and exfiltrate tokens, achieving full account takeover.

**Credits**: Abdelwahed Madani Yousfi (@vvxhid) / Edoardo Geraci (@b0-n0-b0) / Thomas Rinsma (@ThomasRinsma) From Codean Labs.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/@feathersjs/authentication-oauth
Introduced in: 0Fixed in: 5.0.40
Fixnpm install @feathersjs/authentication-oauth@5.0.40

References