VDB
Sign up
MEDIUM6.5

GHSA-jf5r-8hm2-f872

url-parse incorrectly parses hostname / protocol due to unstripped leading control characters.

Quick fix

GHSA-jf5r-8hm2-f872 — url-parse: upgrade to the fixed version with the command below.

npm install url-parse@1.5.9

Details

Leading control characters in a URL are not stripped when passed into url-parse. This can cause input URLs to be mistakenly be interpreted as a relative URL without a hostname and protocol, while the WHATWG URL parser will trim control characters and treat it as an absolute URL.

If url-parse is used in security decisions involving the hostname / protocol, and the input URL is used in a client which uses the WHATWG URL parser, the decision may be incorrect.

This can also lead to a cross-site scripting (XSS) vulnerability if url-parse is used to check for the javascript: protocol in URLs. See following example: ```js const parse = require('url-parse') const express = require('express') const app = express() const port = 3000

url = parse(\"\\bjavascript:alert(1)\")

console.log(url)

app.get('/', (req, res) => { if (url.protocol !== \"javascript:\") {res.send(\"<a href=\\'\" + url.href + \"\\'>CLICK ME!</a>\")} })

app.listen(port, () => { console.log(`Example app listening on port ${port}`) }) ```

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/url-parse
Introduced in: 0.1.0Fixed in: 1.5.9
Fixnpm install url-parse@1.5.9

References