VDB
Sign up
MEDIUM4.3

GHSA-j3m6-gvm8-mhvw

No permission checks for editing/deleting records with CSV import form

Quick fix

GHSA-j3m6-gvm8-mhvw — silverstripe/admin: upgrade to the fixed version with the command below.

composer require silverstripe/admin:^1.13.19

Details

### Impact Users who don't have edit or delete permissions for records exposed in a `ModelAdmin` can still edit or delete records using the CSV import form, provided they have create permissions.

The likelyhood of a user having create permissions but _not_ having edit or delete permissions is low, but it _is_ possible.

Note that this doesn't affect any `ModelAdmin` which has had the import form disabled via the [`showImportForm` public property](https://api.silverstripe.org/4/SilverStripe/Admin/ModelAdmin.html#property_showImportForm), nor does it impact the `SecurityAdmin` section.

#### Action may be required

If you have a custom implementation of [`BulkLoader`](https://api.silverstripe.org/4/SilverStripe/Dev/BulkLoader.html), you should update your implementation to respect permissions when the return value of [`getCheckPermissions()`](https://api.silverstripe.org/4/SilverStripe/Dev/BulkLoader.html#method_getCheckPermissions) is true.

If you are using any `BulkLoader` in your own project logic, or maintain a module which uses it, you should consider passing `true` to [`setCheckPermissions()`](https://api.silverstripe.org/4/SilverStripe/Dev/BulkLoader.html#method_setCheckPermissions) if the data is provided by users.

**Base CVSS:** [4.3](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:L/A:N/E:F/RL:O/RC:C&version=3.1) **Reported by:** Guy Sartorelli from Silverstripe

### References - https://www.silverstripe.org/download/security-releases/CVE-2023-49783

Are you affected?

Enter the version of the package you're using.

Affected packages

Packagist/silverstripe/admin
Introduced in: 1.0.0Fixed in: 1.13.19
Fixcomposer require silverstripe/admin:^1.13.19
Packagist/silverstripe/admin
Introduced in: 2.0.0Fixed in: 2.1.8
Fixcomposer require silverstripe/admin:^2.1.8

References