GHSA-hhjv-jq77-cmvx
zeptoclaw has Android device shell blocklist bypass via argument permutation
Details
### Summary [zeptoclaw](https://github.com/qhkm/zeptoclaw) implements a [blocklist](https://github.com/qhkm/zeptoclaw/blob/fe2ef07cfec5bb46b42cdd65f52b9230c03e9270/src/tools/android/actions.rs#L413-L424) to prevent dangerous commands running in android device shell, but this blocklist has several blocked commands with argements in the pattern literal, such as `rm -f` and `rm -rf`, this can be simply bypassed by using different orders for these arguments, such as `rm -r -f` or `rm -fr` etc.
### Details As in code [src/tools/android/actions.rs#L413-L424](https://github.com/qhkm/zeptoclaw/blob/fe2ef07cfec5bb46b42cdd65f52b9230c03e9270/src/tools/android/actions.rs#L413-L424), we can see the `rm -f` and `rm -rf` are hard coded and thus can be simply bypassed via `rm -r -f` or `rm -fr` etc. ```rust pub async fn device_shell(adb: &AdbExecutor, cmd: &str) -> Result<String> { // Normalize whitespace for blocklist check let normalized: String = cmd.split_whitespace().collect::<Vec<_>>().join(" "); let lower = normalized.to_lowercase();
let blocked = [ "rm -rf", "rm -r", "reboot", "factory_reset", "wipe", "format", "dd if=", "mkfs", "flash", "fastboot", ]; for pattern in &blocked { if lower.contains(pattern) { return Err(ZeptoError::Tool(format!( "Blocked dangerous command containing '{}'", pattern ))); } } ```
### PoC Set up [zeptoclaw](https://github.com/qhkm/zeptoclaw) with an Android tool and then run the command `rm -f -r` etc.
### Impact Unauthorized command executed in Android device.
### Credit [@zpbrent](https://github.com/zpbrent)
Are you affected?
Enter the version of the package you're using.
Affected packages
0Fixed in: 0.6.2Upgrade zeptoclaw to 0.6.2 or newer (ecosystem crates.io).
References
- https://github.com/qhkm/zeptoclaw/security/advisories/GHSA-hhjv-jq77-cmvx[WEB]
- https://github.com/qhkm/zeptoclaw/commit/68916c3e4f3af107f11940b27854fc7ef517058b[WEB]
- https://github.com/qhkm/zeptoclaw[PACKAGE]
- https://github.com/qhkm/zeptoclaw/blob/fe2ef07cfec5bb46b42cdd65f52b9230c03e9270/src/tools/android/actions.rs#L413-L424[WEB]