GHSA-hf43-47q4-fhq5
XWiki Commons missing escaping of `{` in Velocity escapetool allows remote code execution
Quick fix
GHSA-hf43-47q4-fhq5 — org.xwiki.commons:xwiki-commons-velocity: upgrade to the fixed version with the command below.
# pom.xml: bump <version>14.10.19</version> for org.xwiki.commons:xwiki-commons-velocityDetails
### Impact The HTML escaping of escaping tool that is used in XWiki doesn't escape `{`, which, when used in certain places, allows XWiki syntax injection and thereby remote code execution.
To reproduce in an XWiki installation, open `<xwiki-host>/xwiki/bin/view/Panels/PanelLayoutUpdate?place=%7B%7B%2Fhtml%7D%7D%7B%7Basync%20async%3Dfalse%7D%7D%7B%7Bvelocity%7D%7D%23evaluate(%24request.eval)%7B%7B%2Fvelocity%7D%7D%7B%7B%2Fasync%7D%7D&eval=Hello%20from%20URL%20Parameter!%20I%20got%20programming%3A%20%24services.security.authorization.hasAccess(%27programming%27)` where `<xwiki-host>` is the URL of your XWiki installation. If this displays `You are not admin on this place Hello from URL Parameter! I got programming: true`, the installation is vulnerable.
### Patches The vulnerability has been fixed on XWiki 14.10.19, 15.5.5, and 15.9 RC1.
### Workarounds Apart from upgrading, there is no generic workaround. However, replacing `$escapetool.html` by `$escapetool.xml` in XWiki documents fixes the vulnerability. In a standard XWiki installation, we're only aware of the document `Panels.PanelLayoutUpdate` that exposes this vulnerability, patching this document is thus a workaround. Any extension could expose this vulnerability and might thus require patching, too.
### References - https://github.com/xwiki/xwiki-commons/commit/b94142e2a66ec32e89eacab67c3da8d91f5ef93a - https://jira.xwiki.org/browse/XCOMMONS-2828 - https://jira.xwiki.org/browse/XWIKI-21438
Are you affected?
Enter the version of the package you're using.
Affected packages
3.0.1Fixed in: 14.10.19# pom.xml: bump <version>14.10.19</version> for org.xwiki.commons:xwiki-commons-velocity15.0-rc-1Fixed in: 15.5.4# pom.xml: bump <version>15.5.4</version> for org.xwiki.commons:xwiki-commons-velocity15.6-rc-1Fixed in: 15.9-rc-1# pom.xml: bump <version>15.9-rc-1</version> for org.xwiki.commons:xwiki-commons-velocityReferences
- https://github.com/xwiki/xwiki-commons/security/advisories/GHSA-hf43-47q4-fhq5[WEB]
- https://nvd.nist.gov/vuln/detail/CVE-2024-31996[ADVISORY]
- https://github.com/xwiki/xwiki-commons/commit/b0805160ec7b01ee12417e79cb384e60ae4817aa[WEB]
- https://github.com/xwiki/xwiki-commons/commit/b94142e2a66ec32e89eacab67c3da8d91f5ef93a[WEB]
- https://github.com/xwiki/xwiki-commons/commit/ed7ff515a2436a1c6dcbd0c6ca0c41e434d58915[WEB]
- https://github.com/xwiki/xwiki-commons[PACKAGE]
- https://jira.xwiki.org/browse/XCOMMONS-2828[WEB]
- https://jira.xwiki.org/browse/XWIKI-21438[WEB]