VDB
Sign up
HIGH

GHSA-ff5x-w9wg-h275

Holder can generate proof of ownership for credentials it does not control in vp-toolkit

Quick fix

GHSA-ff5x-w9wg-h275 — vp-toolkit: upgrade to the fixed version with the command below.

npm install vp-toolkit@0.2.2

Details

### Impact The [`verifyVerifiablePresentation()`](https://github.com/rabobank-blockchain/vp-toolkit/blob/master/src/service/signers/verifiable-presentation-signer.ts#L97) method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the [`credentialSubject.id`](https://github.com/rabobank-blockchain/vp-toolkit-models/blob/develop/src/model/verifiable-credential.ts#L150) DID matches the signer of the VP proof.

The **verifier** is impacted by this vulnerability.

### Patches Patch will be available in version 0.2.2.

### Workarounds - Compute the address out of the `verifiablePresentation.proof.n.verificationMethod` using `getAddressFromPubKey()` from `crypt-util@0.1.5` and match it with the `credentialSubject.id` address from the credential.

### References [Github issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14)

### For more information If you have any questions or comments about this advisory: * Discuss in the existing [issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14) * [Contact me](https://github.com/rabomarnix)

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/vp-toolkit
Introduced in: 0Fixed in: 0.2.2
Fixnpm install vp-toolkit@0.2.2

References