GHSA-cxjh-pqwp-8mfp
follow-redirects' Proxy-Authorization header kept across hosts
Quick fix
GHSA-cxjh-pqwp-8mfp — follow-redirects: upgrade to the fixed version with the command below.
npm install follow-redirects@1.15.6Details
When using [axios](https://github.com/axios/axios), its dependency follow-redirects only clears authorization header during cross-domain redirect, but allows the proxy-authentication header which contains credentials too.
## Steps To Reproduce & PoC
Test code:
```js const axios = require('axios');
axios.get('http://127.0.0.1:10081/', { headers: { 'AuThorization': 'Rear Test', 'ProXy-AuthoriZation': 'Rear Test', 'coOkie': 't=1' } }) .then((response) => { console.log(response); }) ```
When I meet the cross-domain redirect, the sensitive headers like authorization and cookie are cleared, but proxy-authentication header is kept.
## Impact
This vulnerability may lead to credentials leak.
## Recommendations
Remove proxy-authentication header during cross-domain redirect
### Recommended Patch
[follow-redirects/index.js:464](https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b)
```diff - removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers); + removeMatchingHeaders(/^(?:authorization|proxy-authorization|cookie)$/i, this._options.headers); ```
Are you affected?
Enter the version of the package you're using.
Affected packages
References
- https://github.com/follow-redirects/follow-redirects/security/advisories/GHSA-cxjh-pqwp-8mfp[WEB]
- https://nvd.nist.gov/vuln/detail/CVE-2024-28849[ADVISORY]
- https://github.com/psf/requests/issues/1885[WEB]
- https://github.com/follow-redirects/follow-redirects/commit/c4f847f85176991f95ab9c88af63b1294de8649b[WEB]
- https://hackerone.com/reports/2390009[WEB]
- https://fetch.spec.whatwg.org/#authentication-entries[WEB]
- https://github.com/follow-redirects/follow-redirects[PACKAGE]
- https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/VOIF4EPQUCKDBEVTGRQDZ3CGTYQHPO7Z[WEB]