VDB
Sign up
CRITICAL9.3

GHSA-cjx3-73hr-rpw7

http4s-scala-xml has an XML External Entity (XXE) processing issue

Quick fix

GHSA-cjx3-73hr-rpw7 — org.http4s:http4s-scala-xml_2.12: upgrade to the fixed version with the command below.

# pom.xml: bump <version>0.24.1</version> for org.http4s:http4s-scala-xml_2.12

Details

http4s-scala-xml provides `EntityDecoder[F, scala.xml.Elem]` instances that parse XML message bodies. These decoders used a `javax.xml.parsers.SAXParserFactory` obtained from `SAXParserFactory.newInstance` without any security configuration. With the JDK's default settings, the parser resolves DOCTYPE declarations, external general and parameter entities, and external DTDs.

An application that uses these decoders to parse untrusted XML is vulnerable to XML External Entity (XXE) attacks. An attacker can craft a request that:

- discloses local files readable by the service process, - performs server-side request forgery (SSRF) against internal network resources, and/or - causes denial of service through entity expansion.

### Impact

Any service that derives an XML `EntityDecoder` from this library and parses attacker-controlled input is affected.

### Patches

The default SAXParserFactory is now hardened: - secure processing is enabled - `DOCTYPE` declarations are disallowed - external general/parameter entities and external DTD loading are disabled - DTD URIs are not resolved - XInclude is disabled.

These defaults match `scala.xml.XMLLoader`'s defaults since 2.0.0.

### Workarounds

Before upgrading, override `ElemInstances#saxFactory` with a hardened factory.

```scala val secured = new ElemInstances { override protected val saxFactory = { val f = javax.xml.parsers.SAXParserFactory.newInstance f.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true) // etc. f } } import secured._ ```

Are you affected?

Enter the version of the package you're using.

Affected packages

Maven/org.http4s:http4s-scala-xml_2.12
Introduced in: 0Fixed in: 0.24.1
Fix# pom.xml: bump <version>0.24.1</version> for org.http4s:http4s-scala-xml_2.12
Maven/org.http4s:http4s-scala-xml_2.13
Introduced in: 0Fixed in: 0.24.1
Fix# pom.xml: bump <version>0.24.1</version> for org.http4s:http4s-scala-xml_2.13
Maven/org.http4s:http4s-scala-xml_2.13
Introduced in: 1.0.0-M1Fixed in: 1.0.0-M39
Fix# pom.xml: bump <version>1.0.0-M39</version> for org.http4s:http4s-scala-xml_2.13
Maven/org.http4s:http4s-scala-xml_3
Introduced in: 0Fixed in: 0.24.1
Fix# pom.xml: bump <version>0.24.1</version> for org.http4s:http4s-scala-xml_3
Maven/org.http4s:http4s-scala-xml_3
Introduced in: 1.0.0-M1Fixed in: 1.0.0-M39
Fix# pom.xml: bump <version>1.0.0-M39</version> for org.http4s:http4s-scala-xml_3

References