VDB
Sign up
HIGH8.8

GHSA-93hq-5wgc-jc82

GovernorCompatibilityBravo may trim proposal calldata

Quick fix

GHSA-93hq-5wgc-jc82 — @openzeppelin/contracts: upgrade to the fixed version with the command below.

npm install @openzeppelin/contracts@4.8.3

Details

### Impact

The proposal creation entrypoint (`propose`) in `GovernorCompatibilityBravo` allows the creation of proposals with a `signatures` array shorter than the `calldatas` array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The `ProposalCreated` event correctly represents what will eventually execute, but the proposal parameters as queried through `getActions` appear to respect the original intended calldata.

### Patches

This issue has been patched in v4.8.3.

### Workarounds

Ensure that all proposals that pass through governance have equal length `signatures` and `calldatas` parameters.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/@openzeppelin/contracts
Introduced in: 4.3.0Fixed in: 4.8.3
Fixnpm install @openzeppelin/contracts@4.8.3
npm/@openzeppelin/contracts-upgradeable
Introduced in: 4.3.0Fixed in: 4.8.3
Fixnpm install @openzeppelin/contracts-upgradeable@4.8.3

References