VDB
Sign up
MEDIUM4.4

GHSA-8vp7-j5cj-vvm2

Ability to expose data in Sylius by using an unintended serialisation group

Quick fix

GHSA-8vp7-j5cj-vvm2 — sylius/resource-bundle: upgrade to the fixed version with the command below.

composer require sylius/resource-bundle:^1.4.6

Details

### Impact

ResourceBundle accepts and uses any serialisation groups to be passed via a HTTP header. This might lead to data exposure by using an unintended serialisation group - for example it could make Shop API use a more permissive group from Admin API.

Anyone exposing an API with ResourceBundle's controller is affected. The vulnerable versions are: `<1.3 || >=1.3.0 <=1.3.12 || >=1.4.0 <=1.4.5 || >=1.5.0 <=1.5.0 || >=1.6.0 <=1.6.2`.

### Patches

The patch is provided for ResourceBundle 1.3.13, 1.4.6, 1.5.1 and 1.6.3, but not for any versions below 1.3.

After it is applied, It allows to choose only the groups that are defined in `serialization_groups` or `allowed_serialization_groups` route definition. Any group not defined in those will not be used.

This behaviour might be a BC break for those using custom groups via the HTTP header, please adjust `allowed_serialization_groups` accordingly.

### Workarounds

Service `sylius.resource_controller.request_configuration_factory` can be overridden with an implementation copied from `\Sylius\Bundle\ResourceBundle\Controller\RequestConfigurationFactory` where the part that handles custom serialisation groups is deleted.

Are you affected?

Enter the version of the package you're using.

Affected packages

Packagist/sylius/resource-bundle
Introduced in: 1.4.0Fixed in: 1.4.6
Fixcomposer require sylius/resource-bundle:^1.4.6
Packagist/sylius/resource-bundle
Introduced in: 1.5.0Fixed in: 1.5.1
Fixcomposer require sylius/resource-bundle:^1.5.1
Packagist/sylius/resource-bundle
Introduced in: 1.6.0Fixed in: 1.6.3
Fixcomposer require sylius/resource-bundle:^1.6.3
Packagist/sylius/sylius
Introduced in: 0Fixed in: 1.3.12
Fixcomposer require sylius/sylius:^1.3.12
Packagist/sylius/sylius
Introduced in: 1.4.0Fixed in: 1.4.4
Fixcomposer require sylius/sylius:^1.4.4
Packagist/sylius/resource-bundle
Introduced in: 1.0.0Fixed in: 1.3.13
Fixcomposer require sylius/resource-bundle:^1.3.13

References