VDB
Sign up
LOW

GHSA-8g29-8xwr-qmhr

@grackle-ai/server JSON.parse lacks try-catch logic in its gRPC Service AdapterConfig Handling

Quick fix

GHSA-8g29-8xwr-qmhr — @grackle-ai/server: upgrade to the fixed version with the command below.

npm install @grackle-ai/server@0.70.6

Details

### Impact

`JSON.parse(env.adapterConfig)` is called without error handling in three locations within the gRPC service. While the data originates from the server's own SQLite database and should always be valid JSON, database corruption, migration errors, or unexpected state could cause an unhandled exception that crashes the gRPC handler.

Additionally, the parsed result is cast as `Record<string, unknown>` and passed to adapter methods without property validation, creating a theoretical prototype pollution surface if the database is compromised.

**Affected code:** - `packages/server/src/grpc-service.ts:415` — `reconnectOrProvision` handler - `packages/server/src/grpc-service.ts:482` — `stopEnvironment` handler - `packages/server/src/grpc-service.ts:498` — `destroyEnvironment` handler

### Patches

**Fix:** Wrap in try-catch and return a meaningful gRPC error: ```typescript let config: Record<string, unknown>; try { config = JSON.parse(env.adapterConfig) as Record<string, unknown>; } catch { throw new ConnectError("Invalid adapter configuration", Code.Internal); } ```

### Workarounds

Ensure database integrity. Back up the SQLite database regularly.

### Resources

- CWE-754: Improper Check for Unusual or Exceptional Conditions - File: `packages/server/src/grpc-service.ts`

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/@grackle-ai/server
Introduced in: 0Fixed in: 0.70.6
Fixnpm install @grackle-ai/server@0.70.6

References