VDB
Sign up
HIGH7.5

GHSA-78h2-9frx-2jm8

Go JOSE Panics in JWE decryption

Quick fix

GHSA-78h2-9frx-2jm8 — github.com/go-jose/go-jose/v4: upgrade to the fixed version with the command below.

go get github.com/go-jose/go-jose/v4@v4.1.4

Details

### Impact

Decrypting a JSON Web Encryption (JWE) object will panic if the `alg` field indicates a key wrapping algorithm ([one ending in `KW`](https://pkg.go.dev/github.com/go-jose/go-jose/v4#pkg-constants), with the exception of `A128GCMKW`, `A192GCMKW`, and `A256GCMKW`) and the `encrypted_key` field is empty. The panic happens when `cipher.KeyUnwrap()` in `key_wrap.go` attempts to allocate a slice with a zero or negative length based on the length of the `encrypted_key`.

This code path is reachable from `ParseEncrypted()` / `ParseEncryptedJSON()` / `ParseEncryptedCompact()` followed by `Decrypt()` on the resulting object. Note that the parse functions take a list of accepted key algorithms. If the accepted key algorithms do not include any key wrapping algorithms, parsing will fail and the application will be unaffected.

This panic is also reachable by calling `cipher.KeyUnwrap()` directly with any `ciphertext` parameter less than 16 bytes long, but calling this function directly is less common.

Panics can lead to denial of service.

### Fixed In

4.1.4 and v3.0.5

### Workarounds

If the list of `keyAlgorithms` passed to `ParseEncrypted()` / `ParseEncryptedJSON()` / `ParseEncryptedCompact()` does not include key wrapping algorithms (those ending in `KW`), your application is unaffected.

If your application uses key wrapping, you can prevalidate to the JWE objects to ensure the `encrypted_key` field is nonempty. If your application accepts JWE Compact Serialization, apply that validation to the corresponding field of that serialization (the data between the first and second `.`).

### Thanks

Thanks to Datadog's Security team for finding this issue.

Are you affected?

Enter the version of the package you're using.

Affected packages

Go/github.com/go-jose/go-jose/v4
Introduced in: 0Fixed in: 4.1.4
Fixgo get github.com/go-jose/go-jose/v4@v4.1.4
Go/github.com/go-jose/go-jose/v3
Introduced in: 0Fixed in: 3.0.5
Fixgo get github.com/go-jose/go-jose/v3@v3.0.5
Go/github.com/go-jose/go-jose
Introduced in: 0

No fixed version published yet for github.com/go-jose/go-jose (go modules). Pin to a known-safe version or switch to an alternative.

References