VDB
Sign up
HIGH8.1

GHSA-667r-xxjv-c9mm

fastify vulnerable to request body replacement via an async validation result collision

Quick fix

GHSA-667r-xxjv-c9mm — fastify: upgrade to the fixed version with the command below.

npm install fastify@5.12.2

Details

### Impact

Fastify runs a route's validator and, for a result shaped like `{ value, error }`, unwraps it: an `error` becomes a validation failure and `value` replaces the request part. This convention is intended for synchronous custom compilers (for example Joi). A JSON Schema `$async` validator, however, resolves with the validated data itself, so Fastify applied the same unwrapping to it. If a request part validated by an `$async` schema contains a `value` property, Fastify replaced the whole request part with that nested value before the handler ran, so a `value` or `error` property in the payload was attacker-controlled. An application that dispatches operations from the validated request body could then act on data that never satisfied the route schema, leading to unauthorized state changes or disclosure. Reaching the vulnerable path requires the route to use an `$async` request schema.

### Patches

Fastify no longer treats an asynchronous validation result as a `{ value, error }` wrapper: an async validator's resolved value is used only to determine pass or fail, and it can no longer replace the request part or inject an error. The synchronous custom-compiler contract is unchanged. Patched in fastify `5.12.2` and `6.0.0`.

### Workarounds

If upgrading is not immediately possible, avoid `$async` request schemas, or perform the security-sensitive check in an `onRequest` or `preHandler` hook rather than relying on the schema-validated request part. Custom async validator compilers should signal failure by throwing (rejecting) rather than returning an `{ error }` object.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/fastify
Introduced in: 0Fixed in: 5.12.2
Fixnpm install fastify@5.12.2

References