GHSA-5pf6-2qwx-pxm2
Go SDK for CloudEvents's use of WithRoundTripper to create a Client leaks credentials
Quick fix
GHSA-5pf6-2qwx-pxm2 — github.com/cloudevents/sdk-go/v2: upgrade to the fixed version with the command below.
go get github.com/cloudevents/sdk-go/v2@v2.15.2Details
### Impact _What kind of vulnerability is it? Who is impacted?_ Using cloudevents.WithRoundTripper to create a cloudevents.Client with an authenticated http.RoundTripper causes the go-sdk to leak credentials to arbitrary endpoints.
The relevant code is [here](https://github.com/cloudevents/sdk-go/blob/67e389964131d55d65cd14b4eb32d57a47312695/v2/protocol/http/protocol.go#L104-L110) (also inline, emphasis added):
<pre>if p.Client == nil { p.Client = **http.DefaultClient** }
if p.roundTripper != nil { p.Client.**Transport = p.roundTripper** } </pre>
When the transport is populated with an authenticated transport such as: - [oauth2.Transport](https://pkg.go.dev/golang.org/x/oauth2#Transport) - [idtoken.NewClient(...).Transport](https://pkg.go.dev/google.golang.org/api/idtoken#NewClient)
... then http.DefaultClient is modified with the authenticated transport and will start to send Authorization tokens to **any endpoint** it is used to contact!
Found and patched by: @tcnghia and @mattmoor
### Patches v.2.15.2
Are you affected?
Enter the version of the package you're using.
Affected packages
0Fixed in: 2.15.2go get github.com/cloudevents/sdk-go/v2@v2.15.2References
- https://github.com/cloudevents/sdk-go/security/advisories/GHSA-5pf6-2qwx-pxm2[WEB]
- https://github.com/cloudevents/sdk-go/commit/de2f28370b0d2a0f64f92c0c6139fa4b8a7c3851[WEB]
- https://github.com/cloudevents/sdk-go[PACKAGE]
- https://github.com/cloudevents/sdk-go/blob/67e389964131d55d65cd14b4eb32d57a47312695/v2/protocol/http/protocol.go#L104-L110[WEB]