GHSA-5jpm-x58v-624v
Netty's HttpPostRequestDecoder can OOM
Quick fix
GHSA-5jpm-x58v-624v — io.netty:netty-codec-http: upgrade to the fixed version with the command below.
# pom.xml: bump <version>4.1.108.Final</version> for io.netty:netty-codec-httpDetails
### Summary The `HttpPostRequestDecoder` can be tricked to accumulate data. I have spotted currently two attack vectors
### Details 1. While the decoder can store items on the disk if configured so, there are no limits to the number of fields the form can have, an attacher can send a chunked post consisting of many small fields that will be accumulated in the `bodyListHttpData` list. 2. The decoder cumulates bytes in the `undecodedChunk` buffer until it can decode a field, this field can cumulate data without limits
### PoC
Here is a Netty branch that provides a fix + tests : https://github.com/vietj/netty/tree/post-request-decoder
Here is a reproducer with Vert.x (which uses this decoder) https://gist.github.com/vietj/f558b8ea81ec6505f1e9a6ca283c9ae3
### Impact Any Netty based HTTP server that uses the `HttpPostRequestDecoder` to decode a form.
Are you affected?
Enter the version of the package you're using.
Affected packages
0Fixed in: 4.1.108.Final# pom.xml: bump <version>4.1.108.Final</version> for io.netty:netty-codec-httpReferences
- https://github.com/netty/netty/security/advisories/GHSA-5jpm-x58v-624v[WEB]
- https://nvd.nist.gov/vuln/detail/CVE-2024-29025[ADVISORY]
- https://github.com/netty/netty/commit/0d0c6ed782d13d423586ad0c71737b2c7d02058c[WEB]
- https://gist.github.com/vietj/f558b8ea81ec6505f1e9a6ca283c9ae3[WEB]
- https://github.com/netty/netty[PACKAGE]
- https://github.com/vietj/netty/tree/post-request-decoder[WEB]
- https://lists.debian.org/debian-lts-announce/2024/06/msg00015.html[WEB]