VDB
Sign up
HIGH7.2

GHSA-3vjf-82ff-p4r3

Incorrect protocol extraction via \r, \n and \t characters

Quick fix

GHSA-3vjf-82ff-p4r3 — urijs: upgrade to the fixed version with the command below.

npm install urijs@1.19.11

Details

\r, \n and \t characters in user-input URLs can potentially lead to incorrect protocol extraction when using npm package urijs prior to version 1.19.11.

This can lead to XSS when the module is used to prevent passing in malicious javascript: links into HTML or Javascript (see following example): ```` const parse = require('urijs') const express = require('express') const app = express() const port = 3000

input = "ja\r\nvascript:alert(1)" url = parse(input)

console.log(url)

app.get('/', (req, res) => { if (url.protocol !== "javascript:") {res.send("<iframe src=\'" + input + "\'>CLICK ME!</iframe>")} })

app.listen(port, () => { console.log(`Example app listening on port ${port}`) }) ````

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/urijs
Introduced in: 0Fixed in: 1.19.11
Fixnpm install urijs@1.19.11

References