VDB
Sign up
MEDIUM

GHSA-2h2m-v2mg-656c

Craft Commerce has Stored XSS in Product Type Name

Quick fix

GHSA-2h2m-v2mg-656c — craftcms/commerce: upgrade to the fixed version with the command below.

composer require craftcms/commerce:^5.5.2

Details

## Summary

Stored XSS via Product Type names. The name is not sanitized when displayed in user permissions settings.

The vulnerable input (source) is in Commerce (Product Type settings), but the sink is in CMS user permissions settings. Reporting to Commerce GHSA since the input originates here.

Users are recommended to update to the patched 5.5.2 release to mitigate the issue.

--- ## Proof of Concept

### Required Permissions (Attacker)

- Admin access (to edit Commerce settings)

### Steps to Reproduce

1. Log in as attacker with admin permissions. 2. Go to **Commerce** -> **Settings** -> **Product Types** (`/admin/commerce/settings/producttypes`). 3. Create a new Product Type. 4. Set **Name** to: ```html <img src=x onerror="alert('XSS-ProductType')" hidden> ``` 5. Save the Product Type. 6. Go to **Users** -> Edit any user -> Click on **Permissions** tab (`/admin/users/{UserID}/permissions`). 7. Alert fires instantly (when the Product Type checkbox renders).

## Resources

https://github.com/craftcms/commerce/commit/7e1dedf06038c8e70dce0187b7048d4ab8ffb75c

Are you affected?

Enter the version of the package you're using.

Affected packages

Packagist/craftcms/commerce
Introduced in: 5.0.0Fixed in: 5.5.2
Fixcomposer require craftcms/commerce:^5.5.2
Packagist/craftcms/commerce
Introduced in: 4.0.0-RC1Fixed in: 4.10.1
Fixcomposer require craftcms/commerce:^4.10.1

References