VDB
Sign up
MEDIUM6.8

GHSA-2frx-2596-x5r6

gitoxide does not detect SHA-1 collision attacks

Details

### Summary gitoxide uses SHA-1 hash implementations without any collision detection, leaving it vulnerable to hash collision attacks.

### Details gitoxide uses the `sha1_smol` or `sha1` crate, both of which implement standard SHA-1 without any mitigations for collision attacks. This means that two distinct Git objects with colliding SHA-1 hashes would break the Git object model and integrity checks when used with gitoxide.

The SHA-1 function is considered cryptographically insecure. However, in the wake of the SHAttered attacks, this issue was mitigated in Git 2.13.0 in 2017 by using the [sha1collisiondetection](https://github.com/crmarcstevens/sha1collisiondetection) algorithm by default and producing an error when known SHA-1 collisions are detected. Git is in the process of migrating to using SHA-256 for object hashes, but this has not been rolled out widely yet and gitoxide does not support SHA-256 object hashes.

### PoC The following program demonstrates the problem, using the two [SHAttered PDFs](https://shattered.io/):

```rust use sha1_checked::{CollisionResult, Digest};

fn sha1_oid_of_file(filename: &str) -> gix::ObjectId { let mut hasher = gix::features::hash::hasher(gix::hash::Kind::Sha1); hasher.update(&std::fs::read(filename).unwrap()); gix::ObjectId::Sha1(hasher.digest()) }

fn sha1dc_oid_of_file(filename: &str) -> Result<gix::ObjectId, String> { // Matches Git’s behaviour. let mut hasher = sha1_checked::Builder::default().safe_hash(false).build(); hasher.update(&std::fs::read(filename).unwrap()); match hasher.try_finalize() { CollisionResult::Ok(digest) => Ok(gix::ObjectId::Sha1(digest.into())), CollisionResult::Mitigated(_) => unreachable!(), CollisionResult::Collision(digest) => Err(format!( "Collision attack: {}", gix::ObjectId::Sha1(digest.into()).to_hex() )), } }

fn main() { dbg!(sha1_oid_of_file("shattered-1.pdf")); dbg!(sha1_oid_of_file("shattered-2.pdf")); dbg!(sha1dc_oid_of_file("shattered-1.pdf")); dbg!(sha1dc_oid_of_file("shattered-2.pdf")); } ```

The output is as follows:

``` [src/main.rs:24:5] sha1_oid_of_file("shattered-1.pdf") = Sha1(38762cf7f55934b34d179ae6a4c80cadccbb7f0a) [src/main.rs:25:5] sha1_oid_of_file("shattered-2.pdf") = Sha1(38762cf7f55934b34d179ae6a4c80cadccbb7f0a) [src/main.rs:26:5] sha1dc_oid_of_file("shattered-1.pdf") = Err( "Collision attack: 38762cf7f55934b34d179ae6a4c80cadccbb7f0a", ) [src/main.rs:27:5] sha1dc_oid_of_file("shattered-2.pdf") = Err( "Collision attack: 38762cf7f55934b34d179ae6a4c80cadccbb7f0a", ) ```

The latter behaviour matches Git.

Since the SHAttered PDFs are not in a valid format for Git objects, a direct proof‐of‐concept using higher‐level APIs cannot be immediately demonstrated without significant computational resources.

### Impact An attacker with the ability to mount a collision attack on SHA-1 like the [SHAttered](https://shattered.io/) or [SHA-1 is a Shambles](https://sha-mbles.github.io/) attacks could create two distinct Git objects with the same hash. This is becoming increasingly affordable for well‐resourced attackers, with the Shambles researchers in 2020 estimating $45k for a chosen‐prefix collision or $11k for a classical collision, and projecting less than $10k for a chosen‐prefix collision by 2025. The result could be used to disguise malicious repository contents, or potentially exploit assumptions in the logic of programs using gitoxide to cause further vulnerabilities.

This vulnerability affects any user of gitoxide, including `gix-*` library crates, that reads or writes Git objects.

Are you affected?

Enter the version of the package you're using.

Affected packages

crates.io/gix-features
Introduced in: 0Fixed in: 0.41.0

Upgrade gix-features to 0.41.0 or newer (ecosystem crates.io).

crates.io/gix-commitgraph
Introduced in: 0Fixed in: 0.27.0

Upgrade gix-commitgraph to 0.27.0 or newer (ecosystem crates.io).

crates.io/gix-index
Introduced in: 0Fixed in: 0.39.0

Upgrade gix-index to 0.39.0 or newer (ecosystem crates.io).

crates.io/gix-object
Introduced in: 0Fixed in: 0.48.0

Upgrade gix-object to 0.48.0 or newer (ecosystem crates.io).

crates.io/gix-odb
Introduced in: 0Fixed in: 0.68.0

Upgrade gix-odb to 0.68.0 or newer (ecosystem crates.io).

crates.io/gix-pack
Introduced in: 0Fixed in: 0.58.0

Upgrade gix-pack to 0.58.0 or newer (ecosystem crates.io).

crates.io/gitoxide
Introduced in: 0Fixed in: 0.42.0

Upgrade gitoxide to 0.42.0 or newer (ecosystem crates.io).

crates.io/gitoxide-core
Introduced in: 0Fixed in: 0.46.0

Upgrade gitoxide-core to 0.46.0 or newer (ecosystem crates.io).

crates.io/gix
Introduced in: 0Fixed in: 0.71.0

Upgrade gix to 0.71.0 or newer (ecosystem crates.io).

crates.io/gix-archive
Introduced in: 0Fixed in: 0.20.0

Upgrade gix-archive to 0.20.0 or newer (ecosystem crates.io).

crates.io/gix-blame
Introduced in: 0Fixed in: 0.1.0

Upgrade gix-blame to 0.1.0 or newer (ecosystem crates.io).

crates.io/gix-config
Introduced in: 0Fixed in: 0.44.0

Upgrade gix-config to 0.44.0 or newer (ecosystem crates.io).

crates.io/gix-diff
Introduced in: 0Fixed in: 0.51.0

Upgrade gix-diff to 0.51.0 or newer (ecosystem crates.io).

crates.io/gix-dir
Introduced in: 0Fixed in: 0.13.0

Upgrade gix-dir to 0.13.0 or newer (ecosystem crates.io).

crates.io/gix-discover
Introduced in: 0Fixed in: 0.39.0

Upgrade gix-discover to 0.39.0 or newer (ecosystem crates.io).

crates.io/gix-filter
Introduced in: 0Fixed in: 0.18.0

Upgrade gix-filter to 0.18.0 or newer (ecosystem crates.io).

crates.io/gix-fsck
Introduced in: 0Fixed in: 0.10.0

Upgrade gix-fsck to 0.10.0 or newer (ecosystem crates.io).

crates.io/gix-merge
Introduced in: 0Fixed in: 0.4.0

Upgrade gix-merge to 0.4.0 or newer (ecosystem crates.io).

crates.io/gix-negotiate
Introduced in: 0Fixed in: 0.19.0

Upgrade gix-negotiate to 0.19.0 or newer (ecosystem crates.io).

crates.io/gix-protocol
Introduced in: 0Fixed in: 0.49.0

Upgrade gix-protocol to 0.49.0 or newer (ecosystem crates.io).

crates.io/gix-ref
Introduced in: 0Fixed in: 0.51.0

Upgrade gix-ref to 0.51.0 or newer (ecosystem crates.io).

crates.io/gix-revision
Introduced in: 0Fixed in: 0.33.0

Upgrade gix-revision to 0.33.0 or newer (ecosystem crates.io).

crates.io/gix-revwalk
Introduced in: 0Fixed in: 0.19.0

Upgrade gix-revwalk to 0.19.0 or newer (ecosystem crates.io).

crates.io/gix-status
Introduced in: 0Fixed in: 0.18.0

Upgrade gix-status to 0.18.0 or newer (ecosystem crates.io).

crates.io/gix-traverse
Introduced in: 0Fixed in: 0.45.0

Upgrade gix-traverse to 0.45.0 or newer (ecosystem crates.io).

crates.io/gix-worktree
Introduced in: 0Fixed in: 0.40.0

Upgrade gix-worktree to 0.40.0 or newer (ecosystem crates.io).

crates.io/gix-worktree-state
Introduced in: 0Fixed in: 0.18.0

Upgrade gix-worktree-state to 0.18.0 or newer (ecosystem crates.io).

References