VDB
Sign up
LOW

GHSA-24v3-254g-jv85

Tuta Mail has DOM attribute and CSS injection in its Contact Viewer feature

Quick fix

GHSA-24v3-254g-jv85 — @tutao/tutanota-utils: upgrade to the fixed version with the command below.

npm install @tutao/tutanota-utils@314.251111.0

Details

### Impact Users importing contacts from untrusted sources.

Specifically crafted contact data can lead to some of DOM modifications for the link button next to the field e.g. the link address can be overriden. CSS can be manipulated to give the button arbitrary look and change it's size so that any click on the screen would lead to the specified URL. Modifying event listeners does *not* seem to be possible so no JS can be executed (which would also be prevented by CSP).

## Technical details The data is included as part of the [mithril's hyperscript selector](https://mithril.js.org/hyperscript.html#css-selectors). It is possible to define a value like `][href=https://ddg.gg][style=position:fixed;width:150vw;height:200vh` which will be included in the selector passed to Mithril and will be interpreted as part of the code.

### Patches https://github.com/tutao/tutanota/commit/e28345f5f78f628f9d5c04e785f79543f01dca8b

### Workarounds Do not open contact viewer on unpatched versions. If the contact was opened, close the app or use keyboard shortcuts to switch to another part of the app.

Are you affected?

Enter the version of the package you're using.

Affected packages

npm/@tutao/tutanota-utils
Introduced in: 0Fixed in: 314.251111.0
Fixnpm install @tutao/tutanota-utils@314.251111.0

References