VDB
KO
HIGH 7.5

GHSA-5vjc-7cxw-4w6j

Thumbor has Regex Denial of Service (ReDoS) in `convolution` filter

Quick fix

GHSA-5vjc-7cxw-4w6j — thumbor: upgrade to the fixed version with the command below.

pip install --upgrade 'thumbor>=7.8.0'

Details

### Summary The regular expression used to parse the `convolution` filter exhibits exponential-time backtracking for certain inputs, enabling a Regular Expression Denial of Service (ReDoS).

### Details The RegExp for `convolution` is defined as `convolution\((?:\s*((?:[-]?[\d]+\.?[\d]*[;])*(?:[-]?[\d]+\.?[\d]*))\s*)(?:,\s*([\d]+)\s*)(?:,\s*([Tt]rue|[Ff]alse|1|0)\s*)?\)`. Within this expression a dangerous subpattern effectively behaves like `(\d+)*,\d+`.

### PoC A filter string containing many repeated values will exhaust `re.match`: - `convolution(-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11)` - http://localhost:8888/unsafe/0x0/smart/filters:convolution(-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11;-11)/x.png

The evaluation occurs on https://github.com/thumbor/thumbor/blob/master/thumbor/filters/__init__.py#L189.

### Impact A specially crafted URL will lead to denial of service, as new images won't be processed until `re.match` returns.

Are you affected?

Enter the version of the package you're using.

Affected packages

PyPI / thumbor
Introduced in: 0 Fixed in: 7.8.0
Fix pip install --upgrade 'thumbor>=7.8.0'

References